[ 
https://issues.apache.org/jira/browse/FLINK-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118300#comment-14118300
 ] 

ASF GitHub Bot commented on FLINK-1086:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/incubator-flink/pull/111

    [FLINK-1086] Replaced jcl with slf4j and log4j with logback.

    Replaced the jcl logging interface with slf4j and log4j with logback. 
Removed also log4j specific code so Flink can easily be executed using a 
different slf4j binding. This work also standardises the logging configuration 
which is now exclusively done by specifying a logback.xml configuration file. 
This file is either put in the classpath (e.g. src/main/resources/) or given 
via the environment property -Dlogback.configurationFile. If no configuration 
is provided then the default configuration of logback is used.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/incubator-flink slf4j

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #111
    
----
commit 6f1737333176b04ca8a496eb470c918f097de705
Author: Till Rohrmann <[email protected]>
Date:   2014-08-28T10:36:53Z

    Replaced jcl with slf4j and log4j with logback.
    
    Excluded kafkas transitive dependencies: jmxtools and jmxri.
    
    Corrected encoder pattern in logback.xml
    
    Removed explicit logging access. Loggers are now configured by 
configuration files. Fixed Yarn issue with multiple logging bindings.

----


> Update logging system
> ---------------------
>
>                 Key: FLINK-1086
>                 URL: https://issues.apache.org/jira/browse/FLINK-1086
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>
> As a preparative step for the reworking of the rpc infrastructure, we should 
> update the logging infrastructure. I propose to replace jcl with slf4j and to 
> get rid of all logging framework specific code. This would us allow to easily 
> switch the logging framework by exchanging the slf4j bindings. In the context 
> of this work, we can switch to a more modern logging framework, namely 
> logback instead of log4j.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to