[
https://issues.apache.org/jira/browse/FLINK-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14121185#comment-14121185
]
ASF GitHub Bot commented on FLINK-1086:
---------------------------------------
Github user uce commented on the pull request:
https://github.com/apache/incubator-flink/pull/111#issuecomment-54443513
Thanks for adding the documentation. :-)
I've checked the configuration files of the tests and bash scripts. I
didn't check every single file, where you replaced the log4j logger though, but
since everything is compiling and the tests are running, it should be fine (the
test that is failing is unrelated to this PR, see
[FLINK-1077](https://issues.apache.org/jira/browse/FLINK-1077)).
+1 to merge. I like the new logging pattern, which now includes the thread:
```
11:33:11.842 [Nephele Executor Thread 2] INFO
org.apache.flink.runtime.execution.ExecutionStateTransition - JM:
ExecutionState set from RUNNING to FINISHING for task CHAIN DataSource
(TextInputFormat
(file:/var/folders/3_/h2rwvy1541g0x_m9bjpqnhfc0000gn/T/org.apache.flink.test.example)
-> FlatMap (org.apache.flink.example.java.wordcount.WordCount$Tokenizer) ->
Combine(SUM(1)) (3/4)
```
> Update logging system
> ---------------------
>
> Key: FLINK-1086
> URL: https://issues.apache.org/jira/browse/FLINK-1086
> Project: Flink
> Issue Type: Bug
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
>
> As a preparative step for the reworking of the rpc infrastructure, we should
> update the logging infrastructure. I propose to replace jcl with slf4j and to
> get rid of all logging framework specific code. This would us allow to easily
> switch the logging framework by exchanging the slf4j bindings. In the context
> of this work, we can switch to a more modern logging framework, namely
> logback instead of log4j.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
