[
https://issues.apache.org/jira/browse/FLINK-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14206177#comment-14206177
]
ASF GitHub Bot commented on FLINK-1040:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/194#discussion_r20138315
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/tuple/TupleGenerator.java ---
@@ -323,9 +534,12 @@ private static void modifyJoinProjectOperator(File
root) throws IOException {
sb.append("\t\t * Projects a pair of joined elements to
a {@link Tuple} with the previously selected fields. \n");
sb.append("\t\t * Requires the classes of the fields of
the resulting tuples. \n");
sb.append("\t\t * \n");
+ sb.append("\t\t *");
for (int i = 0; i < numFields; i++) {
- sb.append("\t\t * @param type" + i + " The
class of field '"+i+"' of the result tuples.\n");
+ sb.append(" @param type" + i + " The class of
field '"+i+"' of the result tuples. ");
--- End diff --
This looks like the change that removed the new line and reformatted the
JavaDocs.
> Make type() call in projections optional (or remove it)
> -------------------------------------------------------
>
> Key: FLINK-1040
> URL: https://issues.apache.org/jira/browse/FLINK-1040
> Project: Flink
> Issue Type: Improvement
> Components: Java API
> Reporter: Stephan Ewen
> Priority: Minor
> Labels: simple, starter
>
> I think the type() call should be optional. The compiler can also cast the
> data set directly and the result type is computed from the input types
> anyways.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
