[
https://issues.apache.org/jira/browse/FLINK-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14206190#comment-14206190
]
ASF GitHub Bot commented on FLINK-1040:
---------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/194#issuecomment-62519985
Hi @dukechain,
thanks a lot for this contribution! Removing the need for the ``types()``
call is really great!
As commented inline, I would replace the current API for the projection
operator by your implementation, instead of adding new API methods. With your
solution, the old project API becomes obsolete. I know, this is an API breaking
change, but users only need to remove the types call. Maybe, we can even add a
dummy ``types()`` method to the ``ProjectOperator`` and mark it as deprecated.
Porting the API, would also require to adapt all examples and test cases
that use projection.
Flink's documentation is also contained in the git repository as .md files.
We did this to keep documenation and code in sync. The adapted documenation
should be part of an API changing PR. You find the documenation in the ./docs
folder. The following files need to be adapted:
- ./docs/programming_guide.md
- ./docs/dataset_transformations.md
Again, great work and thanks for your contribution!
> Make type() call in projections optional (or remove it)
> -------------------------------------------------------
>
> Key: FLINK-1040
> URL: https://issues.apache.org/jira/browse/FLINK-1040
> Project: Flink
> Issue Type: Improvement
> Components: Java API
> Reporter: Stephan Ewen
> Priority: Minor
> Labels: simple, starter
>
> I think the type() call should be optional. The compiler can also cast the
> data set directly and the result type is computed from the input types
> anyways.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
