platinumhamburg commented on code in PR #1477:
URL: https://github.com/apache/fluss/pull/1477#discussion_r2253009343
##########
fluss-server/src/main/java/com/alibaba/fluss/server/zk/ZooKeeperClient.java:
##########
@@ -222,8 +222,27 @@ public void deleteTableAssignment(long tableId) throws
Exception {
public void deletePartitionAssignment(long partitionId) throws Exception {
String path = PartitionIdZNode.path(partitionId);
- zkClient.delete().deletingChildrenIfNeeded().forPath(path);
- LOG.info("Deleted table assignment for partition id {}.", partitionId);
+ // delete partition assignment ZNode will recursively delete all the
children which may
Review Comment:
Could this introduce inconsistent behavior during coordinator failover?
Should we consider using ZooKeeper TransactionOp to solve this problem? I think
dividing the ZK delete operation into asynchronous background sub-tasks may
compromise the integrity of the DROP semantic. @wuchong What are your thoughts
on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
