platinumhamburg commented on code in PR #1477:
URL: https://github.com/apache/fluss/pull/1477#discussion_r2253430021


##########
fluss-server/src/main/java/com/alibaba/fluss/server/zk/ZooKeeperClient.java:
##########
@@ -222,8 +222,27 @@ public void deleteTableAssignment(long tableId) throws 
Exception {
 
     public void deletePartitionAssignment(long partitionId) throws Exception {
         String path = PartitionIdZNode.path(partitionId);
-        zkClient.delete().deletingChildrenIfNeeded().forPath(path);
-        LOG.info("Deleted table assignment for partition id {}.", partitionId);
+        // delete partition assignment ZNode will recursively delete all the 
children which may

Review Comment:
   @LB-Yu Thank you for your detailed explanation. The design approach you've 
outlined  appears to be well-reasoned. I believe this PR is in good shape and I 
will proceed with testing it shortly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to