luoyuxia commented on code in PR #1359:
URL: https://github.com/apache/fluss/pull/1359#discussion_r2260050705
##########
fluss-dist/src/main/resources/bin/config.sh:
##########
@@ -133,6 +139,7 @@ KEY_ENV_SSH_OPTS="env.ssh.opts"
KEY_ZK_HEAP_MB="zookeeper.heap.mb"
KEY_REMOTE_DATA_DIR="remote.data.dir"
+KEY_ENV_HADOOP_CLASSPATH="env.hadoop.class-path"
Review Comment:
I'd like not to introduce the key. Let's user just use hadoop classpath env
variable
##########
fluss-dist/src/main/resources/bin/config.sh:
##########
@@ -287,6 +294,10 @@ if [ -z "${REMOTE_DATA_DIR}" ]; then
REMOTE_DATA_DIR=$(readFromConfig ${KEY_REMOTE_DATA_DIR} "" "${YAML_CONF}")
fi
+if [ -z "${HADOOP_CLASSPATH}" ]; then
Review Comment:
remove this.
##########
website/docs/maintenance/filesystems/hdfs.md:
##########
@@ -38,6 +38,20 @@ remote.data.dir: hdfs://namenode:50010/path/to/remote/storage
To allow for easy adoption, you can use the same configuration keys in Fluss'
server.yaml as in Hadoop's `core-site.xml`.
You can see the configuration keys in Hadoop's
[`core-site.xml`](https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/core-default.xml).
+#### Hadoop Environment Configuration
+
+To use the machine hadoop environment, instead of Fluss' embedded Hadoop,
follow these steps:
+
+**Step 1: Set Hadoop Classpath**
+```bash
+export HADOOP_CLASSPATH=`hadoop classpath`
+```
+
+**Step 2: Add the following to your configuration file**
+```yaml
+plugin.classloader.parent-first-patterns.default:
java.,com.alibaba.fluss.,javax.annotation.,org.slf4j,org.apache.log4j,org.apache.logging,org.apache.commons.logging,ch.qos.logback,hdfs-site,core-site,org.apache.hadoop.,META-INF
Review Comment:
I'd merge this after #1222 , so that users can configure less
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
