beryllw commented on code in PR #1359:
URL: https://github.com/apache/fluss/pull/1359#discussion_r2269098159


##########
fluss-common/src/main/java/com/alibaba/fluss/config/ConfigOptions.java:
##########
@@ -61,6 +61,12 @@ public class ConfigOptions {
                 "ch.qos.logback"
             };
 
+    @Internal
+    public static final String[] PARENT_FIRST_HDFS_PATTERNS =
+            new String[] {
+                "hdfs-site", "core-site", "org.apache.hadoop.", "META-INF",

Review Comment:
   > But if user already set HADOOP_HOME, won't hdfs-site and core-site in 
HADOOP_HOME be loaded? 
   
   Yes, but for plugin ClassLoader, without 
`classloader.parent-first-patterns.default` it cannot retrieve the `hdfs-site` 
resource.
   The same problem exists for `META-INF`.
   
   `org.apache.hadoop.` only for hadoop class resource, make plugin ClassLoader 
can retrieve hadoop class but not `hdfs-site` and `META-INF` resource.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to