swuferhong commented on code in PR #1258:
URL: https://github.com/apache/fluss/pull/1258#discussion_r2276421944
##########
fluss-client/src/main/java/com/alibaba/fluss/client/write/RecordAccumulator.java:
##########
@@ -531,10 +534,10 @@ private long bucketReady(
private long batchReady(
boolean exhausted,
- ServerNode leader,
+ Integer leader,
long waitedTimeMs,
boolean full,
- Set<ServerNode> readyNodes,
+ Set<Integer> readyNodes,
long nextReadyCheckDelayMs) {
if (!readyNodes.contains(leader)) {
Review Comment:
Change to `int`, as the `!= null` checking already done for `leader` while
call this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]