swuferhong commented on code in PR #1258:
URL: https://github.com/apache/fluss/pull/1258#discussion_r2281108248
##########
fluss-client/src/main/java/com/alibaba/fluss/client/utils/MetadataUtils.java:
##########
@@ -153,6 +152,19 @@ public static Cluster sendMetadataRequestAndRebuildCluster(
newPartitionIdByPath =
newTableMetadata.partitionIdByPath;
}
+ // update the leader id to check whether the
leader is alive or not.
+ newBucketLocations.forEach(
+ (physicalTablePath, bucketLocations) ->
+ bucketLocations.forEach(
+ bucketLocation -> {
+ Integer leader =
bucketLocation.getLeader();
+ if (leader != null
+ &&
newAliveTabletServers.get(leader)
+ ==
null) {
+
bucketLocation.setLeader(null);
Review Comment:
I didn't encounter errors after removing it during local testing and
simulated upgrade/downgrade job tests. We can proceed with removing it for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
