naivedogger commented on code in PR #5:
URL: https://github.com/apache/fluss-rust/pull/5#discussion_r2335967019
##########
crates/fluss/src/record/arrow.rs:
##########
@@ -438,7 +439,7 @@ pub fn to_arrow_type(fluss_type: &DataType) ->
ArrowDataType {
DataType::Time(_) => todo!(),
DataType::Timestamp(_) => todo!(),
DataType::TimestampLTz(_) => todo!(),
- DataType::Bytes(_) => todo!(),
+ DataType::Bytes(_) => ArrowDataType::Binary,
Review Comment:
Not yet. I will move this into a later pr.
##########
crates/fluss/src/record/mod.rs:
##########
@@ -147,6 +147,10 @@ impl ScanRecords {
Self { records }
}
+ pub fn into_records(self) -> HashMap<TableBucket, Vec<ScanRecord>> {
Review Comment:
fixed
##########
crates/fluss/src/row/column.rs:
##########
@@ -45,6 +45,14 @@ impl ColumnarRow {
pub fn set_row_id(&mut self, row_id: usize) {
self.row_id = row_id
}
+
+ pub fn get_row_id(&self) -> usize {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@fluss.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
