naivedogger commented on code in PR #5: URL: https://github.com/apache/fluss-rust/pull/5#discussion_r2335967575
########## crates/fluss/src/row/column.rs: ########## @@ -45,6 +45,14 @@ impl ColumnarRow { pub fn set_row_id(&mut self, row_id: usize) { self.row_id = row_id } + + pub fn get_row_id(&self) -> usize { + self.row_id + } + + pub fn get_record_batch(&self) -> &Arc<RecordBatch> { Review Comment: fixed ########## crates/fluss/src/row/datum.rs: ########## @@ -47,6 +47,8 @@ pub enum Datum<'a> { #[display("{0}")] Int64(i64), #[display("{0}")] + Float32(F32), Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@fluss.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org