luoyuxia commented on code in PR #1700:
URL: https://github.com/apache/fluss/pull/1700#discussion_r2354679074
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/tiering/committer/FlussTableLakeSnapshotCommitter.java:
##########
@@ -88,7 +88,8 @@ public void commit(long tableId, CommittedLakeSnapshot
committedLakeSnapshot)
Long partitionId = partitionBucket.f0;
if (partitionId == null) {
tableBucket = new TableBucket(tableId, partitionBucket.f1);
- flussTableLakeSnapshot.addBucketOffset(tableBucket,
entry.getValue());
+ flussTableLakeSnapshot.addBucketOffsetAndTimestamp(
+ tableBucket, entry.getValue(), -1);
Review Comment:
add comment:
```
we use -1 since we don't store timestamp in lake snapshot property for
simplicity, it may cause the timestamp to be -1 during constructing lake
snapshot to commit to Fluss. But it should happen rarely and should be a normal
value after next tiering.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
