Copilot commented on code in PR #1700:
URL: https://github.com/apache/fluss/pull/1700#discussion_r2354614083
##########
fluss-flink/fluss-flink-common/src/test/java/org/apache/fluss/flink/tiering/committer/TieringCommitOperatorTest.java:
##########
@@ -413,13 +483,17 @@ private void verifyLakeSnapshot(
TablePath tablePath,
long tableId,
long expectedSnapshotId,
- Map<TableBucket, Long> expectedLogEndOffsets)
+ Map<TableBucket, Long> expectedLogEndOffsets,
+ Map<TableBucket, Long> expectedMaxTimestamp)
throws Exception {
LakeSnapshot lakeSnapshot =
admin.getLatestLakeSnapshot(tablePath).get();
assertThat(lakeSnapshot.getSnapshotId()).isEqualTo(expectedSnapshotId);
assertThat(lakeSnapshot.getTableBucketsOffset()).isEqualTo(expectedLogEndOffsets);
- // check the tableId has been send to mark finished
+ // TODO: replace with LakeSnapshot when support max timestamp
+ verifyLakeSnapshotMaxTimestamp(tableId, expectedMaxTimestamp);
+
+ // check the tableId has been sent to mark finished
Review Comment:
Grammar inconsistency: 'sent' should be 'send' to match the original comment
style, or change line 522 to 'sent' for consistency.
```suggestion
// check the tableId has been send to mark finished
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
