LiebingYu commented on code in PR #1452:
URL: https://github.com/apache/fluss/pull/1452#discussion_r2340611097
##########
fluss-rpc/src/main/proto/FlussApi.proto:
##########
@@ -530,6 +530,43 @@ message LakeTieringHeartbeatResponse {
repeated PbHeartbeatRespForTable failed_table_resp = 5;
}
+message AddServerTagRequest {
+ repeated int32 server_ids = 1 [packed = true];
+ required int32 server_tag = 2;
+}
+
+message AddServerTagResponse {
+}
+
+message RemoveServerTagRequest {
+ repeated int32 server_ids = 1 [packed = true];
+ required int32 server_tag = 2;
+}
+
+message RemoveServerTagResponse {
+}
+
+message RebalanceRequest {
+ repeated int32 goals = 1 [packed = true];
+ required bool dry_run = 2;
+}
+
+message RebalanceResponse {
+ repeated PbRebalancePlanForTable plan_for_table = 1;
+}
+
+message ListRebalanceProcessRequest {
+}
+
+message ListRebalanceProcessResponse {
+ repeated PbRebalanceProcessForTable process_for_table = 1;
+}
Review Comment:
I have a question here. Rebalance task are store in `CoordinatorContext` via
`Map<TableBucket, RebalanceResultForBucket>`, and `Admin#listRebalanceProcess`
alse return `Map<TableBucket, RebalanceResultForBucket>`. So can we directly
use the following format?
```protobuf
message ListRebalanceProcessResponse {
repeated PbRebalanceProcessForBucket process_for_bucket = 1;
}
message PbRebalanceProcessForBucket {
required int64 table_id = 1;
required int64 partition_id = 2;
required int32 bucket_id = 3;
repeated int32 original_replicas = 4 [packed = true];
repeated int32 new_replicas = 5 [packed = true];
required int32 rebalance_status = 6;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
