luoyuxia commented on code in PR #1770:
URL: https://github.com/apache/fluss/pull/1770#discussion_r2387002792
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/source/enumerator/FlinkSourceEnumerator.java:
##########
@@ -580,9 +581,8 @@ private List<SourceSplitBase>
generateHybridLakeFlussSplits() {
pendingHybridLakeFlussSplits =
lakeSplitGenerator.generateHybridLakeFlussSplits();
return pendingHybridLakeFlussSplits;
} catch (Exception e) {
- LOG.error("Failed to get hybrid lake fluss splits, won't take
splits in lake.", e);
+ throw new FlinkRuntimeException("Failed to generate hybrid lake
fluss splits", e);
Review Comment:
Let's just throw exception to notify users generate lake splits fails which
should be exceptions happens that should be resolved by users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
