Copilot commented on code in PR #1770: URL: https://github.com/apache/fluss/pull/1770#discussion_r2387042323
########## website/docs/streaming-lakehouse/integrate-data-lakes/iceberg.md: ########## @@ -266,17 +421,21 @@ PROPERTIES ( ); ``` -```sql title="Query Examples" +#### Query Examples + +```sql title="Basic Query" -- Basic query SELECT COUNT(*) FROM iceberg_catalog.fluss.orders; +``` +```sql title="Time Travel Query" -- Time travel query -SELECT * FROM iceberg_catalog.fluss.orders -FOR SYSTEM_VERSION AS OF 123456789; +SELECT * FROM iceberg_catalog.fluss.orders FOR SYSTEM_VERSION AS OF 123456789; +``` --- Query with bucket filtering for efficiency -SELECT * FROM iceberg_catalog.fluss.orders -WHERE __bucket = 1 AND __offset >= 100; +```sql title="Query with bucket filtering for efficiency" +-- Time travel query Review Comment: The comment says 'Time travel query' but the query is actually demonstrating bucket filtering. The comment should be '-- Bucket filtering query' to match the query's purpose. ```suggestion -- Bucket filtering query ``` ########## fluss-lake/fluss-lake-iceberg/src/main/java/org/apache/fluss/lake/iceberg/tiering/IcebergLakeCommitter.java: ########## @@ -49,7 +49,6 @@ import java.io.IOException; import java.util.Arrays; -import java.util.Collections; import java.util.List; Review Comment: The removed import `java.util.Collections` is no longer needed since `Collections.reverse()` has been replaced with reverse iteration. This is good cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
