wuchong opened a new pull request, #1922:
URL: https://github.com/apache/fluss/pull/1922

   <!--
   *Thank you very much for contributing to Fluss - we are happy that you want 
to help us improve Fluss. To help the community review your contribution in the 
best possible way, please go through the checklist below, which will get the 
contribution into a shape in which it can be best reviewed.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GitHub 
issue](https://github.com/apache/fluss/issues). Exceptions are made for typos 
in JavaDoc or documentation files, which need no issue.
   
     - Name the pull request in the format "[component] Title of the pull 
request", where *[component]* should be replaced by the name of the component 
being changed. Typically, this corresponds to the component label assigned to 
the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are 
unsure about which is the best component.
   
     - Fill out the template below to describe the changes contributed by the 
pull request. That will give reviewers the context they need to do the review.
   
     - Make sure that the change passes the automated tests, i.e., `mvn clean 
verify` passes.
   
     - Each pull request should address only one issue, not mix up code from 
multiple issues.
   
   
   **(The sections below can be removed for hotfixes or typos)**
   -->
   
   ### Purpose
   
   This fixes the release issues mentioned by JB in the vote thread: 
https://lists.apache.org/thread/pyccbmxoz9wnf6m3blcrcvj8j9gzyow8
   
   
   > +1 (binding)
   > 
   > NB: the binary distribution should be fixed (see later).
   > 
   > I checked:
   > - Source distribution
   > -- incubating is in the name/version
   > -- signature and checksum are good
   > -- DISCLAIMER is there
   > -- LICENSE and NOTICE are good (NB: it would be good to mention Maven
   > in LICENSE/NOTICE as we bundle mvnw in the source distribution)
   > -- No binary file found in the source distribution
   > -- ASF header is present in expected files and good (just missing in a
   > couple of README.md, but not blocker/required)
   > - Binary distribution
   > -- incubating is in the name/version
   > -- signature and checksum are good
   > -- DISCLAIMER is missing in the source distribution
   > -- LICENSE is missing in the root directory (for Fluss itself)
   > -- LICENSE files in the licenses directory and NOTICE file are good
   > -- ASF header is present in configuration file (in the conf folder)
   > 
   > Thanks,
   > Regards
   > JB
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #xxx
   
   <!-- What is the purpose of the change -->
   
   ### Brief change log
   
   - fix the `create_binary_release.sh` to copy the DISCLAIMER and LICENSE from 
the project root directory.
   - Add ASF headers to README.md files
   - Add mvnw files entries in LICENSE and NOTICE
   
   <!-- Please describe the changes made in this pull request and explain how 
they address the issue -->
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to