wuchong commented on code in PR #1922:
URL: https://github.com/apache/fluss/pull/1922#discussion_r2493637898
##########
tools/releasing/create_binary_release.sh:
##########
@@ -68,7 +68,11 @@ make_binary_release() {
$MVN clean package -Prelease -am -Dgpg.skip -Dcheckstyle.skip=true
-DskipTests
cd fluss-dist/target/fluss-${RELEASE_VERSION}-bin
+ cp ${FLUSS_DIR}/LICENSE ./fluss-${RELEASE_VERSION}/LICENSE
Review Comment:
Yes, this copies `LICENSE` file from source code to the binary distribution
to fix the missing `LICENSE` in binary distribution. I think the `LICENSE` file
in source distribution is correct, right?
The `NOTICE` file already exists in binary distribution, this PR just append
the `NOTICE` content in source code into the existing binary `NOTICE` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
