leekeiabstraction commented on PR #1992: URL: https://github.com/apache/fluss/pull/1992#issuecomment-3576001847
Thank you @polyzos for addressing the commends and also providing the data from your tests! That gives a clear picture on the performance. Further response questions below: > This is basically a trade-off for the users. Using InternalRow/GenericRow directly is way more efficient; however, this might come with some extra complexity and boilerplatete code. > For this reason, I want to give flexibility, probably leave the docs as is, with GenericRow being the go-to approach, but also add a section that Pojos can be used directly and maybe highlight this trade-off. IMO, this does not need to be a trade-off. I am curious if you have explored implementation complexity or cons around pushing the Pojo conversion down further so that conversion to/from `InternalRow` can be skipped altogether? From a quick look, it does seem like you have most of the interfaces updated to support it. > Moving forward I'm thinking that maybe it makes sense to add some helper classes that also derive the schema for the table from a Pojo. Trying to understand, does this relate to performance or a separate thread on further changes that you're planning? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
