leekeiabstraction commented on PR #1992: URL: https://github.com/apache/fluss/pull/1992#issuecomment-3576121461
> Can you provide some more context in terms of what you mean - push the conversion further down? > On the scan side, I see you mentioned optimization in the CompletedFetch.toScanRecord(LogRecord), that is something indeed that I didn't think of and might result in some further optimization. My aim is so that we can eliminate performance penalty by avoiding performing conversion twice. By "pushing conversion down", I mean you can do something like moving the RowToPojoConverter method calls into LogScannerImpl/CompletedFetch. Strategy pattern could be useful here. > Is there something also on the write side you are thinking of? Currently not, I'm very new to this code base but it's certainly worth exploring especially if we're also converting twice on the write side. Happy to have a look at the write side as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
