leekeiabstraction commented on code in PR #2038:
URL: https://github.com/apache/fluss/pull/2038#discussion_r2567614535
##########
fluss-lake/fluss-lake-iceberg/pom.xml:
##########
@@ -323,6 +323,11 @@
<relocation>
<pattern>org.apache.iceberg</pattern>
<shadedPattern>org.apache.fluss.lake.iceberg.shaded.org.apache.iceberg</shadedPattern>
+ <excludes>
+
<exclude>org/apache/iceberg/hive/**</exclude>
+
<exclude>org/apache/iceberg/aws/**</exclude>
+
<exclude>org/apache/iceberg/nessie/**</exclude>
+ </excludes>
Review Comment:
Will this approach break the intended isolation of dependencies? E.g. if
something else provide iceberg hive/aws/nessie classes in the classpath of
version different to what Fluss-lake-icebery depends on, I'd expect that we'll
see issues such as NoSuchMethodError.
Should the approach instead be fixing the shading configuration so that
fluss.lake.iceberg contains shaded hive/aws/nessie packages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
