leekeiabstraction commented on code in PR #2038:
URL: https://github.com/apache/fluss/pull/2038#discussion_r2571722050
##########
fluss-lake/fluss-lake-iceberg/pom.xml:
##########
@@ -323,6 +323,11 @@
<relocation>
<pattern>org.apache.iceberg</pattern>
Review Comment:
Great call! If the dependency isolation is not required anymore, removing
shading is much better than leaving some transitives unshaded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
