wuchong commented on code in PR #2105:
URL: https://github.com/apache/fluss/pull/2105#discussion_r2609988544
##########
fluss-common/src/main/java/org/apache/fluss/config/ConfigOptions.java:
##########
@@ -1423,6 +1423,17 @@ public class ConfigOptions {
+ "The auto increment column can only be
used in primary-key table. The data type of the auto increment column must be
INT or BIGINT."
+ "Currently a table can have only one
auto-increment column.");
+ public static final ConfigOption<Boolean>
TABLE_CHANGELOG_IGNORE_UPDATE_BEFORE =
+ key("table.changelog.ignore-update-before")
Review Comment:
Considering we already have `table.delete.behavior = ignore`,
`sink.ignore-delete = true`, I'm afraid the
`table.changelog.ignore-update-before` may confuse it is a sink operation.
I found mysql and PG have similar configurations
```
// PG
replica identity = FULL / default / index
// mysql
binlog_row_image = FULL / minimal / nonblob
```
How about introducing a configuration like
```
table.changelog.image = FULL / NO_UPDATE_BEFORE
```
With default to `FULL`, and we can extend it to support `NO_BLOG`,
`NO_UNCHANGED` in the future.
Besides, we should add documentation to this config that it only emits `+U`
for all inserts and updates, because it avoid lookup previous values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
