platinumhamburg commented on code in PR #2105:
URL: https://github.com/apache/fluss/pull/2105#discussion_r2617771403
##########
fluss-common/src/main/java/org/apache/fluss/config/ConfigOptions.java:
##########
@@ -1423,6 +1423,17 @@ public class ConfigOptions {
+ "The auto increment column can only be
used in primary-key table. The data type of the auto increment column must be
INT or BIGINT."
+ "Currently a table can have only one
auto-increment column.");
+ public static final ConfigOption<Boolean>
TABLE_CHANGELOG_IGNORE_UPDATE_BEFORE =
+ key("table.changelog.ignore-update-before")
Review Comment:
> @platinumhamburg I’ve reconsidered this again, and I think the name
`NO_UPDATE_BEFORE` isn’t quite accurate.
>
> For delete changelog records, they may only contain the key to be deleted,
without the full row data. However, this nuance isn’t reflected in the name
`NO_UPDATE_BEFORE`.
>
> What we really need here is a changelog that functions like a
**Write-Ahead Log (WAL)**, primarily for **durability and recovery**, not for
CDC-style change data capture.
>
> Given that, would it be more appropriate to name this option
`table.changelog.image=WAL`?
Sure, I think that’s a much better design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
