wuchong commented on code in PR #2080:
URL: https://github.com/apache/fluss/pull/2080#discussion_r2625388634
##########
fluss-server/src/main/java/org/apache/fluss/server/replica/ReplicaManager.java:
##########
@@ -997,7 +1006,7 @@ private Map<TableBucket, PutKvResultForBucket>
putToLocalKv(
tableMetrics.incKvMessageIn(entry.getValue().getRecordCount());
tableMetrics.incKvBytesIn(entry.getValue().sizeInBytes());
// metric for cdc log of kv
- tableMetrics.incLogBytesIn(appendInfo.validBytes());
+ tableMetrics.incLogBytesIn(appendInfo.validBytes(),
userContext);
Review Comment:
I also have concerns about this. The cdc log size is not generated by users,
use it as a pricing model may confusing users. Maybe using message num/rate for
kv put/lookup is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
