wuchong commented on code in PR #2080:
URL: https://github.com/apache/fluss/pull/2080#discussion_r2635519697
##########
fluss-common/src/main/java/org/apache/fluss/config/ConfigOptions.java:
##########
@@ -1695,6 +1695,14 @@ public class ConfigOptions {
+ "the CoordinatorServer) it is advisable
to use a port range "
+ "like 9250-9260.");
+ public static final ConfigOption<Duration>
METRICS_MANAGER_INACTIVE_EXPIRATION_TIME =
+ key("metrics.manager.inactive-expiration-time")
Review Comment:
I think default 1 hour is enough for production use-case. I checked Kafka
also not exposing the configuration. Maybe we can remove it.
##########
fluss-common/src/main/java/org/apache/fluss/metrics/MetricNames.java:
##########
@@ -74,6 +74,12 @@ public class MetricNames {
public static final String SERVER_PHYSICAL_STORAGE_LOCAL_SIZE =
"localSize";
public static final String SERVER_PHYSICAL_STORAGE_REMOTE_LOG_SIZE =
"remoteLogSize";
+ //
--------------------------------------------------------------------------------------------
+ // metrics for user
+ //
--------------------------------------------------------------------------------------------
+ public static final String BYTES_IN_COUNT = "bytesInCount";
+ public static final String BYTES_OUT_COUNT = "bytesOutCount";
Review Comment:
`bytesIn` and `bytesOut` already reflect the meaning of the number of bytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
