loserwang1024 commented on code in PR #2083:
URL: https://github.com/apache/fluss/pull/2083#discussion_r2639231540
##########
fluss-flink/fluss-flink-1.18/src/main/java/org/apache/fluss/flink/adapter/CatalogTableAdapter.java:
##########
@@ -37,4 +38,9 @@ public static CatalogTable toCatalogTable(
Map<String, String> options) {
return CatalogTable.of(schema, comment, partitionKeys, options);
}
+
+ public static boolean isMaterializedTable(CatalogBaseTable.TableKind
tableKind) {
+ // flink 1.18 not support MaterializedTable
Review Comment:
Now that we have adapter class here, Please remove CatalogBaseTable class in
fluss-flink-1.18 and fluss-flink-1.19.
##########
fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/adapter/CatalogTableAdapter.java:
##########
@@ -42,4 +43,8 @@ public static CatalogTable toCatalogTable(
.options(options)
.build();
}
+
Review Comment:
Modify the javadoc of this adapter: `A adapter for {@link CatalogTable}
constructor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
