loserwang1024 commented on code in PR #2083:
URL: https://github.com/apache/fluss/pull/2083#discussion_r2641716039
##########
fluss-flink/fluss-flink-1.18/src/main/java/org/apache/fluss/flink/adapter/CatalogTableAdapter.java:
##########
@@ -37,4 +38,9 @@ public static CatalogTable toCatalogTable(
Map<String, String> options) {
return CatalogTable.of(schema, comment, partitionKeys, options);
}
+
+ public static boolean isMaterializedTable(CatalogBaseTable.TableKind
tableKind) {
+ // flink 1.18 not support MaterializedTable
Review Comment:
In fluss-flink-1.18 and fluss-flink-1.19, A CatalogBaseTable is provided
for compile. With your fix, this provided CatalogBaseTable file is no needed
any more.
<img width="549" height="367" alt="image"
src="https://github.com/user-attachments/assets/b3c876e4-cdab-42bf-864b-87a076f4a64a";
/>
I found that you still use it in tests, maybe can removed the tests or move
this class to test class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
