XuQianJin-Stars commented on PR #2079: URL: https://github.com/apache/fluss/pull/2079#issuecomment-3684742836
> Thanks for the contribution @XuQianJin-Stars . > > I think there are the following 4 problems in this PR. > > (1) The current implementation uses `AlignedRow` format as nested row format. We should use the same row format as the parant row, like if it's `CompactedRow`, then the nested row (like `array<row>`) should also use `CompactedRow`. > > (2) The current implementation doesn't support nested row in arrays. > > (3) Please add tests!! You can add tests to verify nested row types > > * row<bool, int, long, string, bytes, timestamp_ltz, timestamp_ntz, date, time> > * array<row<array>> > * row<array<row>> > > in following tests > > * `DefaultCompletedFetchTest#testComplexTypeFetch` > * `FlinkComplexTypeITCase` > > (4) the dependencies and licenses changes seems not necessary. > > I have appended a commit to fix the (1) and (2) problem. Could you fix the other problems? well，i will fix the other problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
