XuQianJin-Stars commented on code in PR #2079:
URL: https://github.com/apache/fluss/pull/2079#discussion_r2643397177
##########
fluss-common/pom.xml:
##########
@@ -62,7 +62,14 @@
<artifactId>fluss-shaded-arrow</artifactId>
</dependency>
- <!-- TODO: these two dependencies need to be shaded. -->
+ <!-- TODO: these three dependencies need to be shaded. -->
+ <!-- Use the Arrow compatible version -->
+ <dependency>
+ <groupId>org.eclipse.collections</groupId>
+ <artifactId>eclipse-collections</artifactId>
+ <version>11.1.0</version>
Review Comment:
> We don't need this, this should be removed.
Reason 1: Purpose
Arrow uses `eclipse-collections` to provide primitive type collections (such
as IntList, LongList) to optimize memory usage and performance, avoiding the
overhead of Java boxing/unboxing operations.
Reason 2: Why Explicit Declaration is Required
Although the project uses `fluss-shaded-arrow`, the `eclipse-collections`
dependency was not included during the shading process, therefore it must be
explicitly declared as a separate dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
