wuchong commented on PR #2241: URL: https://github.com/apache/fluss/pull/2241#issuecomment-3694739517
@sd4324530 thank you. Could you also add this test for flink 1.18 and flink 1.19? This helps verify the added adapter in Flink 1.18 is correct, and not adding adapter in Flink 1.19 is also correct. Besides, could you use **rebase** to rebase your branch onto `main` branch instead of using **merge**? It's suggest not using "git merge" to merge branches, otherwise the changes is hard to track. Please use "git rebase" to rebase branches instead. IntelliJ IDEA provide an easy tool to do git rebase, you can find the tool via `VCS -> Git -> Rebase`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
