wuchong commented on code in PR #2241: URL: https://github.com/apache/fluss/pull/2241#discussion_r2649754295
########## fluss-flink/fluss-flink-1.19/src/test/java/org/apache/fluss/flink/tiering/committer/Flink119TieringCommitOperatorTest.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.fluss.flink.tiering.committer; + +import org.apache.fluss.flink.tiering.TestingLakeTieringFactory; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.runtime.operators.coordination.MockOperatorEventGateway; +import org.apache.flink.runtime.operators.testutils.DummyEnvironment; +import org.apache.flink.streaming.api.operators.StreamOperatorParameters; +import org.apache.flink.streaming.runtime.tasks.SourceOperatorStreamTask; +import org.apache.flink.streaming.util.MockOutput; +import org.apache.flink.streaming.util.MockStreamConfig; +import org.junit.jupiter.api.BeforeEach; + +import java.util.ArrayList; + +/** + * UT for {@link TieringCommitOperator}. Test the compatibility of the `getAttemptNumber` method in + * flink 1.19. + */ +public class Flink119TieringCommitOperatorTest extends TieringCommitOperatorTest { + + @BeforeEach + @Override + void beforeEach() throws Exception { Review Comment: Do not override parent test method, otherwise, it's hard to maintain. If the Flink classes used in test are also not compatible across different Flink versions, we should do the same `adapter` for them (but leave them in test packages only), you can checkout `ResolvedCatalogMaterializedTableAdapter` for an example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
