leekeiabstraction commented on code in PR #116:
URL: https://github.com/apache/fluss-rust/pull/116#discussion_r2650820922
##########
crates/fluss/tests/integration/table.rs:
##########
@@ -446,22 +446,32 @@ mod table_test {
.await
.expect("Failed to poll");
- let records: Vec<_> = scan_records.into_iter().collect();
+ let mut records: Vec<_> = scan_records.into_iter().collect();
+ records.sort_by_key(|r| r.offset());
Review Comment:
Curious, is this sort_by_key needed? What happens if you do not sort?
My assumption is that poll_batch should already return records ordered by
offset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
