leekeiabstraction commented on PR #116: URL: https://github.com/apache/fluss-rust/pull/116#issuecomment-3702420751
> The `sort_by_key` is needed because `poll()` does not guarantee ordering as records may arrive from different buckets or be processed asynchronously. Also thank you again on this becouse that's how i noticed the pattern! > > This follows the existing pattern in the codebase: > > * [table.rs:159](https://github.com/apache/fluss-rust/blob/main/crates/fluss/tests/integration/table.rs#L159) - `append_record_batch_and_scan` > * [table.rs:189](https://github.com/apache/fluss-rust/blob/main/crates/fluss/tests/integration/table.rs#L189), same test with projection You're right. Java side uses inAnyOrder assertion: https://github.com/apache/fluss/blob/bcebe7f48dde96f7085bf14af41ff18afc1f99e6/fluss-client/src/test/java/org/apache/fluss/client/table/scanner/log/RemoteLogScannerITCase.java#L114 Approving! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
