beryllw commented on code in PR #2161:
URL: https://github.com/apache/fluss/pull/2161#discussion_r2661680805
##########
fluss-server/src/main/java/org/apache/fluss/server/kv/KvTablet.java:
##########
@@ -468,8 +474,9 @@ private long applyInsert(
PaddingRow latestSchemaRow,
long logOffset)
throws Exception {
- walBuilder.append(ChangeType.INSERT,
latestSchemaRow.replaceRow(currentValue.row));
- kvPreWriteBuffer.put(key, currentValue.encodeValue(), logOffset);
+ BinaryValue newValue = autoIncProcessor.processAutoInc(currentValue);
Review Comment:
> One point worth noting is that when changelogImage == ChangelogImage.WAL,
the applyInsert method might not be invoked. It would be helpful to clarify the
intended design and expected behavior in this case.
Agree. When changelogImage == ChangelogImage.WAL, auto-Increment column
aren't supported. We could clarify this in the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
