platinumhamburg commented on code in PR #2161:
URL: https://github.com/apache/fluss/pull/2161#discussion_r2666872474
##########
fluss-server/src/main/java/org/apache/fluss/server/kv/KvTablet.java:
##########
@@ -468,8 +474,9 @@ private long applyInsert(
PaddingRow latestSchemaRow,
long logOffset)
throws Exception {
- walBuilder.append(ChangeType.INSERT,
latestSchemaRow.replaceRow(currentValue.row));
- kvPreWriteBuffer.put(key, currentValue.encodeValue(), logOffset);
+ BinaryValue newValue = autoIncProcessor.processAutoInc(currentValue);
Review Comment:
Here, I believe we should support this. ChangelogImage.WAL is an
optimization mode whose core use case is to skip generating UPDATE_BEFORE
records when a user's table does not require UPDATE_BEFORE information. This
significantly reduces the storage, replication (leader-follower), and read
overhead associated with the changelog. Building upon this foundation, skipping
the lookup of the old value to further reduce CPU and I/O overhead is merely an
incremental optimization. Therefore, under the condition changelogImage ==
ChangelogImage.WAL, it's not that we cannot support the auto-increment columns;
rather, we simply cannot benefit from this incremental optimization and would
still need to look up the old value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
