luoyuxia commented on code in PR #138:
URL: https://github.com/apache/fluss-rust/pull/138#discussion_r2678785740
##########
crates/fluss/src/row/compacted/compacted_row_reader.rs:
##########
@@ -52,11 +56,9 @@ impl CompactedRowDeserializer {
DataType::Float(_) =>
Datum::Float32(reader.read_float().into()),
DataType::Double(_) =>
Datum::Float64(reader.read_double().into()),
// TODO: use read_char(length) in the future, but need to keep
compatibility
- DataType::Char(_) | DataType::String(_) =>
Datum::OwnedString(reader.read_string()),
+ DataType::Char(_) | DataType::String(_) =>
Datum::String(reader.read_string()),
// TODO: use read_binary(length) in the future, but need to
keep compatibility
- DataType::Bytes(_) | DataType::Binary(_) => {
- Datum::Blob(reader.read_bytes().into_vec().into())
Review Comment:
let's avoid this copy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
