luoyuxia commented on code in PR #138:
URL: https://github.com/apache/fluss-rust/pull/138#discussion_r2679187340
##########
crates/fluss/src/row/datum.rs:
##########
@@ -296,9 +292,7 @@ impl Datum<'_> {
Datum::Float32(v) => append_value_to_arrow!(Float32Builder,
v.into_inner()),
Datum::Float64(v) => append_value_to_arrow!(Float64Builder,
v.into_inner()),
Datum::String(v) => append_value_to_arrow!(StringBuilder, *v),
- Datum::OwnedString(v) => append_value_to_arrow!(StringBuilder,
v.as_str()),
- Datum::Blob(v) => append_value_to_arrow!(BinaryBuilder,
v.as_ref()),
- Datum::BorrowedBlob(v) => append_value_to_arrow!(BinaryBuilder,
*v),
Review Comment:
Let me first merge your pr since `Owned` also accept reference and value
which is more flexible and I can build based on your pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
