zhaohaidao commented on code in PR #143:
URL: https://github.com/apache/fluss-rust/pull/143#discussion_r2686549477
##########
crates/fluss/src/client/table/log_fetch_buffer.rs:
##########
@@ -148,8 +176,9 @@ impl LogFetchBuffer {
has_completed = true;
}
Err(e) => {
Review Comment:
If I understand correctly, the fetch request is driven by the user's poll
function, rather than automatically retrying in the background?
And some errors, such as outdated metadata, require explicit metadata
updates, not automatic retries.
I looked at the Java code, and it doesn't seem to have any retry logic; it
just completes the fetch request directly?
Please feel free to correct me if I've misunderstood anything. @luoyuxia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
