luoyuxia commented on code in PR #143:
URL: https://github.com/apache/fluss-rust/pull/143#discussion_r2694844076
##########
crates/fluss/src/client/table/log_fetch_buffer.rs:
##########
@@ -148,8 +176,9 @@ impl LogFetchBuffer {
has_completed = true;
}
Err(e) => {
Review Comment:
Yes, In java code, I think it should handle the exception better, it just
silently swallowed the exception. So, the `pendingFetches` will still keep the
fetch for this bucket and no way to tryComplete it again. Then, the scanner
won't send any fetch request for the bucket since it's in `pendingFetches`.
After look the code of hanlding error, I think the curenty rust code is more
rubust with notify the error to user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
