luoyuxia commented on code in PR #143:
URL: https://github.com/apache/fluss-rust/pull/143#discussion_r2694898471
##########
crates/fluss/src/client/table/scanner.rs:
##########
@@ -894,6 +1182,11 @@ impl LogFetcher {
.update_offset(&table_bucket, next_fetch_offset);
}
+ if next_in_line_fetch.is_consumed() &&
next_in_line_fetch.records_read() > 0 {
Review Comment:
Can we pass `LogScannerStatus` into `CompletedFetch`.
The reason is that `drain`(including move offset) is called in other code
paths, it'll be better to wrap the logic in drain` in java. Otherwise, it's
error-prone.
We can do it in other pr, but left todo for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
