luoyuxia commented on code in PR #176:
URL: https://github.com/apache/fluss-rust/pull/176#discussion_r2702281654
##########
crates/fluss/src/rpc/message/produce_log.rs:
##########
@@ -37,7 +37,7 @@ impl ProduceLogRequest {
table_id: i64,
ack: i16,
max_request_timeout_ms: i32,
- ready_batches: &[&ReadyWriteBatch],
+ ready_batches: &mut [ReadyWriteBatch],
Review Comment:
Yes, we need it to be mut here since I have changed the `build` method of
`MemoryLogRecordsArrowBuilder` to use `&mut self` to align with
`KvRecordBatchBuilder` . `KvRecordBatchBuilder` rely much on the mut reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
