luoyuxia commented on code in PR #176:
URL: https://github.com/apache/fluss-rust/pull/176#discussion_r2702293828
##########
crates/fluss/src/client/write/mod.rs:
##########
@@ -33,31 +33,80 @@ mod sender;
mod write_format;
mod writer_client;
+use crate::client::Record::Compacted;
pub use write_format::WriteFormat;
pub use writer_client::WriterClient;
+#[allow(dead_code)]
pub struct WriteRecord<'a> {
- pub row: Record<'a>,
- pub table_path: Arc<TablePath>,
+ record: Record<'a>,
+ table_path: Arc<TablePath>,
+ bucket_key: Option<&'a [u8]>,
+ schema_id: i32,
+ write_format: WriteFormat,
+
+ // only valid for primary key table
+ key: Option<&'a [u8]>,
+ target_columns: Option<&'a [usize]>,
Review Comment:
Consider in the future we will also have `CompactedRow` as the log format, I
will split the enum into `LogWriteRecord` and `KvWriteRecod`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
