loserwang1024 commented on code in PR #1784:
URL: https://github.com/apache/fluss/pull/1784#discussion_r2702302413
##########
fluss-flink/fluss-flink-1.18/src/test/java/org/apache/fluss/flink/sink/Flink118TableSinkITCase.java:
##########
@@ -17,5 +17,25 @@
package org.apache.fluss.flink.sink;
+import org.apache.flink.test.util.AbstractTestBase;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+
/** IT case for {@link FlinkTableSink} in Flink 1.18. */
-public class Flink118TableSinkITCase extends FlinkTableSinkITCase {}
+public class Flink118TableSinkITCase extends FlinkTableSinkITCase {
+ @BeforeEach
+ @Override
+ void before() throws Exception {
+ // invoke here because the AbstractTestBase in 1.18 is junit 4.
+ AbstractTestBase.MINI_CLUSTER_RESOURCE.before();
+ super.before();
+ }
+
+ @AfterEach
+ @Override
+ void after() throws Exception {
+ super.after();
+ // invoke here because the AbstractTestBase in 1.18 is junit 4.
+ AbstractTestBase.MINI_CLUSTER_RESOURCE.after();
+ }
Review Comment:
@wuchong yes, it seems at least three slots are required. However, if not
run AbstractTestBase.MINI_CLUSTER_RESOURCE.before(), won't have 4 slots for
each tm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
