leekeiabstraction commented on code in PR #169:
URL: https://github.com/apache/fluss-rust/pull/169#discussion_r2707303726
##########
crates/fluss/src/client/write/mod.rs:
##########
@@ -110,15 +128,15 @@ impl<'a> WriteRecord<'a> {
pub fn for_upsert(
table_path: Arc<TablePath>,
schema_id: i32,
- bucket_key: &'a [u8],
- key: &'a [u8],
- target_columns: Option<&'a [usize]>,
- row: CompactedRow<'a>,
+ bucket_key: Option<Bytes>,
+ key: Bytes,
+ target_columns: Option<Arc<Vec<usize>>>,
+ row_bytes: Option<RowBytes<'a>>,
) -> Self {
Self {
- record: Record::Kv(KvWriteRecord::new(key, target_columns,
Some(row))),
+ record: Record::Kv(KvWriteRecord::new(key, target_columns,
row_bytes)),
table_path,
- bucket_key: Some(bucket_key),
+ bucket_key,
schema_id,
write_format: WriteFormat::CompactedKv,
Review Comment:
Wired up with kv_format within upserWriterImpl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
