luoyuxia commented on code in PR #169:
URL: https://github.com/apache/fluss-rust/pull/169#discussion_r2708287137
##########
crates/fluss/src/row/compacted/compacted_row.rs:
##########
@@ -153,6 +152,14 @@ impl<'a> InternalRow for CompactedRow<'a> {
fn get_timestamp_ltz(&self, pos: usize, precision: u32) ->
crate::row::datum::TimestampLtz {
self.decoded_row().get_timestamp_ltz(pos, precision)
}
+
+ fn as_encoded_bytes(&self, write_format: WriteFormat) -> Option<&[u8]> {
Review Comment:
can we just remove the parameter `write_format`? At least, curerntly we
don't need this parameter.
For me, this method should just return the encoded bytes, without care about
write format.. To me, it seems that the upper caller should care about write
format and decide to call `as_encoded_bytes` or not.
We can remove the parameter in following pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
