luoyuxia commented on code in PR #184:
URL: https://github.com/apache/fluss-rust/pull/184#discussion_r2709019786
##########
crates/fluss/src/client/write/sender.rs:
##########
@@ -182,23 +187,19 @@ impl Sender {
.iter()
.filter_map(|bucket| records_by_bucket.remove(bucket))
.collect();
- if request_batches.is_empty() {
- continue;
- }
- let request = match ProduceLogRequest::new(
+
+ let write_request = match Self::build_write_request(
Review Comment:
I still prefer the previous code where we explicitly check if
request_batches.is_empty() { continue; }. Making build_write_request return
None feels a bit clunky because it hides the skip logic inside the builder.
Keeping the check in the main loop makes the execution flow more transparent at
a glance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
