fresh-borzoni commented on code in PR #184:
URL: https://github.com/apache/fluss-rust/pull/184#discussion_r2709162018
##########
crates/fluss/src/client/write/batch.rs:
##########
@@ -250,7 +250,7 @@ impl ArrowLogWriteBatch {
pub struct KvWriteBatch {
write_batch: InnerWriteBatch,
kv_batch_builder: KvRecordBatchBuilder,
- target_columns: Option<Arc<Vec<usize>>>,
+ pub target_columns: Option<Arc<Vec<usize>>>,
Review Comment:
nit: better to hide it and not expose directly
``` rust
pub fn target_columns(&self) -> Option<&Arc<Vec<usize>>> {
self.target_columns.as_ref()
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
