luoyuxia commented on code in PR #2419:
URL: https://github.com/apache/fluss/pull/2419#discussion_r2710747950
##########
fluss-filesystems/fluss-fs-s3/pom.xml:
##########
@@ -233,6 +233,10 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-reload4j</artifactId>
</exclusion>
+ <exclusion>
Review Comment:
https://hadoop.apache.org/release/3.4.1.html
"We have also introduced a lean tar which is a small tar file that does not
contain the AWS SDK because the size of AWS SDK is itself 500 MB. This can ease
usage for non AWS users. Even AWS users can add this jar explicitly if desired."
If we use 3.4.1, the fat jar won't be included.
##########
fluss-filesystems/fluss-fs-s3/src/main/java/org/apache/fluss/fs/s3/exception/InvalidCredentialsException.java:
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.fluss.fs.s3.exception;
+
+/** Exception thrown when no credentials were found. */
+public class InvalidCredentialsException extends RuntimeException {
+
+ public static final String E_NO_AWS_CREDENTIALS = "No AWS Credentials";
+
+ public InvalidCredentialsException(String credentialProvider) {
Review Comment:
I'm curious about the class not found issue. I also check the v0.8 jar for s3
```jar tf fluss-fs-s3-0.8.0-incubating.jar | grep SdkClientException
com/amazonaws/SdkClientException.class
```
The same with the jar build with this pr
```
com/amazonaws/SdkClientException.class
```
So, it looks to me that the same problem will also happen in v0.8, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
